Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #28

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

v4 #28

wants to merge 54 commits into from

Conversation

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-image-turntable ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:38am

@nerdyman nerdyman linked an issue Nov 26, 2023 that may be closed by this pull request
@nerdyman nerdyman changed the title 24 add hook to control all state from parent Add hook to control all state from parent Nov 26, 2023
…avoid jitter when changing between 18 and 36 images
Copy link

github-actions bot commented Oct 19, 2024

📦 esbuild Bundle Analysis for react-image-turntable

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
lib/dist/metafile-esm.json dist/index.mjs 6.00 KB 🆕 Added
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: lib/dist/metafile-esm.json, Out file: dist/index.mjs

Path Size
src/useReactImageTurntable.ts ${{\color{Goldenrod}{ ████████████████▋ }}}$ 66.6%, 3.86 KB
src/ReactImageTurntable.tsx ${{\color{Goldenrod}{ ████████▎ }}}$ 33.4%, 1.93 KB
src/index.ts ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@nerdyman nerdyman added the publish-preview Publish a preview package label Oct 19, 2024
Copy link

pkg-pr-new bot commented Oct 19, 2024

Open in Stackblitzexample

npm i https://pkg.pr.new/nerdyman/react-image-turntable@28

commit: de3c9d3

@nerdyman nerdyman changed the title Add hook to control all state from parent v4 Oct 19, 2024
@imujo
Copy link

imujo commented Dec 16, 2024

Hi @nerdyman ,

I noticed that in v4 of the library, you've added functionality for controlling turntable state with a hook from parent. This feature is necessary for my project. I was wondering if you could provide an estimate of when this PR might be merged?

I'd greatly appreciate any information you can share regarding the timeline for this feature.

Thanks in advance, and keep up the great work!

@nerdyman
Copy link
Owner Author

Thanks for the kind words @imujo!

I don't have much time atm to do the v4 release but can do a beta npm release this week with what's currently on this branch so you'll be able to use that in the meantime. I'll drop a message here when it's published.

@nerdyman
Copy link
Owner Author

nerdyman commented Dec 17, 2024

@imujo This has been published, you can get it by installing react-image-turntable@next.

npm install react-image-turntable@next
pnpm install react-image-turntable@next
yarn add react-image-turntable@next

Let me know if you run into any issues.

@imujo
Copy link

imujo commented Dec 18, 2024

@nerdyman Thanks so much for the quick turnaround! I've tested the beta release, and everything works for my project. I really appreciate your responsiveness and effort.

@nerdyman
Copy link
Owner Author

No probs @imujo! Thanks for testing it out 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish-preview Publish a preview package
Projects
None yet
2 participants