Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem is scrolling page in mobile view #36

Open
Abdullah-J01 opened this issue Sep 9, 2024 · 3 comments · May be fixed by #28
Open

Problem is scrolling page in mobile view #36

Abdullah-J01 opened this issue Sep 9, 2024 · 3 comments · May be fixed by #28
Labels
bug Something isn't working has workaround Issue has a viable workaround

Comments

@Abdullah-J01
Copy link

Hi,
mostly, the library works great for my use case but there is one issue
When I am on mobile device and the turntable takes up a lot of real estate on screen, I cannot scroll the page down
This is because the swipe down gesture is detected by turntable and the page does not scroll down like it should
There should be a prop that allow us to disable vertical gesture, so we can scroll through our page without any issue (in mobile view)
Sample: https://mtronicpk-development-vercel-nextjs.vercel.app/products/touch-panel-lcd-4-inch/
(The hero image is turntable)

@Abdullah-J01
Copy link
Author

Fixed in my project by using touch-action: pan-y; on the main div Instead of touch-action: none that is used at the moment

@nerdyman
Copy link
Owner

nerdyman commented Sep 9, 2024

Thanks for raising this @Abdullah-J01

Have you found any issues using touch-action: pan-y? This could be the default instead of none if not.

@nerdyman nerdyman added bug Something isn't working has workaround Issue has a viable workaround labels Sep 9, 2024
@Abdullah-J01
Copy link
Author

Hello,
At the moment, I did not find any issue with pan-y. I've given it to QA for testing
But I think it will be safe to update it

@nerdyman nerdyman linked a pull request Oct 19, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has workaround Issue has a viable workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants