do not raise exception when an optional source file is missing #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12 - missing optional files normally do not raise GTFS::InvalidSourceException anymore
If an optional file is missing,
parse_entity
yields a new empty instance of StringIO, when callingread
on this StringIO, an empty string will be returned causingparse_models
to return an empty array.If a required file is missing, raise GTFS::InvalidSourceException as before.
I added a test on
transfers
field,transfers.txt
is missing invalid_gtfs_missing_optional_files.zip
but callingsource.transfers
does not raise an exception anymore :)