Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPY-64: Not using external diff tools #1891

Open
wants to merge 4 commits into
base: dev/1.x
Choose a base branch
from

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Dec 23, 2024

Fixes #1887

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@SiddhantSadangi SiddhantSadangi added this to the 1.14 milestone Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (9747b21) to head (088bff2).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1891      +/-   ##
===========================================
- Coverage    77.60%   77.52%   -0.08%     
===========================================
  Files          303      303              
  Lines        15384    15384              
===========================================
- Hits         11938    11926      -12     
- Misses        3446     3458      +12     
Flag Coverage Δ
e2e 58.69% <100.00%> (-0.08%) ⬇️
e2e-management 57.22% <100.00%> (-0.04%) ⬇️
e2e-s3 56.03% <100.00%> (-0.04%) ⬇️
e2e-s3-gcs 56.03% <100.00%> (-0.04%) ⬇️
macos 77.17% <100.00%> (-0.12%) ⬇️
py3.10 ?
py3.11 ?
py3.12 58.69% <100.00%> (-18.89%) ⬇️
py3.8 77.50% <100.00%> (-0.06%) ⬇️
py3.9 ?
ubuntu 77.36% <100.00%> (-0.08%) ⬇️
unit 75.60% <100.00%> (-0.04%) ⬇️
windows 76.43% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiddhantSadangi SiddhantSadangi changed the title Not using external diff tools PPY-64: Not using external diff tools Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Neptune Captures Non-Standard Git Patch Format When Using External Diff Viewer
1 participant