Correcting identifiers #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominika Schweier <[email protected]>
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign @efiacor @ciaranjohnston |
Signed-off-by: Dominika Schweier <[email protected]>
Signed-off-by: Dominika Schweier <[email protected]>
liamfallon
reviewed
Oct 29, 2024
content/en/docs/guides/contributor-guides/unit-testing-mockery.md
Outdated
Show resolved
Hide resolved
liamfallon
reviewed
Oct 29, 2024
|
Nice work! Just 2 tiny typos. |
Co-authored-by: Liam Fallon <[email protected]>
|
@liamfallon thanks! corrected the suggestion + one more small thing |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @ciaranjohnston @arora-sagar |
|
/retest |
|
/lgtm |
|
/retest |
Merged
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Gergely Csatari <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting identifiers to follow the guide "Do not surround IP addresses, domain names or any other identifyers with backticks. Use italics (* *) to mark any inline IP address, domain name, file name, file location or similar." https://docs.nephio.org/docs/guides/contributor-guides/documentation/