Fixing some of the linting errors #176
Conversation
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Gergely Csatari <[email protected]>
|
@CsatariGergely vale seems to complain on some capitalization (and couple on choice of wording) errors. PTAL. |
Yep, it is a massive list :) I will also configure it not to fail the check, but only post warnings. I would like to use these as more like recommendations for now. |
Signed-off-by: Gergely Csatari <[email protected]>
|
Now it is strange, that the Vale check is not triggered for every update. |
Signed-off-by: Gergely Csatari <[email protected]>
content/en/docs/release-notes/R2.md
Outdated
| @@ -129,11 +129,11 @@ The following limitations need to be borne in mind: | |||
| does not match src line`. | |||
| If such a message appears, then retry in a little while, as this error may resolve itself. Restarting | |||
| Porch may also help. | |||
| * During specialization, we may have duplicate parameterRef extensions, leading to failed deployments | |||
| * During specialization, we may have duplicate parameterRef extensions, leading to unsuccesfull deployments | |||
There was a problem hiding this comment.
| * During specialization, we may have duplicate parameterRef extensions, leading to unsuccesfull deployments | |
| * During specialization, we may have duplicate parameterRef extensions, leading to unsuccesful deployments |
There was a problem hiding this comment.
I don't know why the word "unsuccessful" is spelt that way in English (it makes no sense) :-D
There was a problem hiding this comment.
Actually I don't know why our doc checking/lint tool would find "failed" deployments offensively, it is a much better wording to capture the reality than an "unsuccessful" deployment.
There was a problem hiding this comment.
Okay, I can change it back to failed, if you think that it is better in this context.
There was a problem hiding this comment.
This is changed back now.
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
CsatariGergely
changed the title
Signed-off-by: Gergely Csatari <[email protected]>
This is fixed now. |
- Moving the env statement in the GitHub workflow - Printing the environment in the ocntext of vale - Adding workds to the accept list - Fixing findings Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
CsatariGergely
changed the title
Signed-off-by: Gergely Csatari <[email protected]>
CsatariGergely
changed the title
|
/assign @arora-sagar @liamfallon This is ready for merge now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is still in the works, do not approve it. I just need the Vale job to run.