Use prettier for formatting instead of eslint #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `npm run lint` now checks formatting with prettier and eslint - `npm run fixlint` now fixes formatting with `prettier --write` and `eslint --fix` - lint-staged also uses `npm run fixlint` to keep things consistent - ci seems to already check formatting with prettier and eslint - added jsdoc type hints to the eslintrc.js file for autocompletion Eslint now uses a blocklist instead of allowlist for ignoring files. It might be easier to not accidentally ignore any new files with this approach. Solves neovim#445
mikavilpas
force-pushed
the
use-prettier-for-formatting-instead-of-eslint
branch
from
3025089 to
f67e2ab
Compare
justinmk
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lintnow checks formatting with prettier and eslint as discussed in ci: drop "eslint-plugin-prettier" dependency #445npm run fixlintnow fixes formatting withprettier --writeandeslint --fixnpm run fixlintto keep things consistentEslint now uses a blocklist instead of allowlist for ignoring files. It might be easier to not
accidentally ignore any new files with this approach.
Solves #445