fix(logger): use custom logger #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before:
● Node host › can run a command from plugin
failed request to "nvim_command" (see $NVIM_NODE_LOG_FILE for details, if it was set)
75 | request(name, args = []) {
76 | // Dummy error, to get stacktrace.
> 77 | const error = new Error(`failed request to "${name}" (see $NVIM_NODE_LOG_FILE for details, if it was set)`);
| ^
78 | return this.asyncRequest(name, args, error.stack);
79 | }
80 | _getArgsByPrefix(...args) {
at NeovimClient.request (../neovim/lib/api/Base.js:77:23)
at NeovimClient.request (../neovim/lib/api/Neovim.js:355:21)
at Object.command (__tests__/integration.test.ts:85:16)
after:
● Node host › can run a command from plugin
nvim_command: Vim:E492: Not an editor command: JSHostTestCmd
67 | return this[DO_REQUEST](name, args).catch(err => {
68 | // XXX: Get a `*.ts stacktrace. If we re-throw `err` we get a `*.js` trace. tsconfig issue?
> 69 | const newError = new Error(err.message);
| ^
70 | this.logger.error(`failed request to "%s": %s: %s`, name, newError.name, newError.message);
71 | throw newError;
72 | });
at ../neovim/lib/api/Base.js:69:34
at Object.<anonymous> (__tests__/integration.test.ts:85:5)
Problem: d9bc2ef #138 allows clients to supply a custom logger, but the logger is not always used. And the winstonLogger is always initialized, even when a custom logger is given. Solution: - Update all logging calls to use the custom logger. - Skip initialization of winstonLogger if a custom logger is given.
cli.js is a low-level, minimal entrypoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution: