fix: console.log() writes to RPC channel #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
force-pushed
the
fixconsolelog
branch
6 times, most recently
from
1be5ec0 to
aac45ab
Compare
before:
{"level":"debug","message":"request -> neovim.api.nvim_list_bufs"}
{"level":"debug","message":"request -> neovim.api.nvim_command"}
{"level":"debug","message":"request -> neovim.api.nvim_get_current_tabpage"}
{"level":"debug","message":"response -> neovim.api.nvim_command: null"}
{"level":"debug","message":"response -> neovim.api.nvim_get_current_tabpage: [object Object]"}
after
2024-03-16 15:01:14 DBG request -> neovim.api.nvim_eval
2024-03-16 15:01:14 DBG request -> neovim.api.nvim_get_current_tabpage
2024-03-16 15:01:15 DBG response -> neovim.api.nvim_get_current_tabpage: [object Object]
2024-03-16 15:01:15 DBG request -> neovim.api.nvim_get_current_tabpage
2024-03-16 15:01:15 DBG request -> neovim.api.nvim_get_current_win
- annotate types. - rename helpers/ => utils/ - there are already other "utils/" directories - helpers is a stupid name
Use findNvim() instead of "which".
Can't do "global beforeAll" because jest sucks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
2d47447 removed "sandboxing" and accidentally also removed the console.log monkey-patching. This means a random call to
console.logcan write to stdout, which breaks the RPC channel.Solution:
Re-implement the patching.
fix #202
fix #329