lint #301
Merged
lint #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
commented
Feb 2, 2024
| @@ -44,13 +52,50 @@ module.exports = { | |||
| 'import/extensions': 'off', | |||
| 'import/prefer-default-export': 'off', | |||
|
|
|||
| '@typescript-eslint/no-namespace': 'error', | |||
| // TODO: '@typescript-eslint/no-floating-promises': 'error', // Promises must catch errors or be awaited. | |||
There was a problem hiding this comment.
This is a useful one but should wait until after a release, since it's a bit risky.
Problem: Can't use newer JS features like `Array.at()` Solution: - Polyfill to es2015, so we can use esnext features in our `.ts` code. - Set `lib=esnext`. This is still compatible with older node.js, because `target=es2015`. - our CI currently tests node.js 14 - our .babelrc.js targets node.js 8
We must disable eslint rules that require new javascript features in
test files, because test files are not currently compiled by `tsc`.
TODO: doesn't look like babel is configured to run on the "neovim"
package. I tried this:
M packages/neovim/package.json
@@ -72,7 +72,7 @@
"test-staged": "npm test --bail --no-cache --findRelatedTests",
"test-missing-apis": "npm run build && node scripts/findMissingApi",
"precommit": "lint-staged",
- "build": "tsc --pretty",
+ "build": "tsc --pretty && babel lib --out-dir lib",
"dev": "npm run build --watch true"
},
"jest": {
M packages/neovim/src/utils/getNvimFromEnv.ts
@@ -149,6 +149,8 @@ export function getNvimFromEnv(
const paths = process.env.PATH.split(delimiter);
const pathLength = paths.length;
const matches = new Array<NvimVersion>();
+ const foo = matches.at(-1);
+ console.log(foo); // test
const unmatchedVersions = new Array<NvimVersion>();
const errors = new Array<GetNvimFromEnvError>();
for (let i = 0; i !== pathLength; i = i + 1) {
Babel didn't translate the file to the desired node.js 8 compatible
syntax (it should replace `matches.at()` with `matches[…]`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more lint rules, including rules from https://github.com/sindresorhus/eslint-plugin-unicorn
Fixed with:
Fix #266