Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lsp/rpc): move transport logic to separate module #31514

Merged
merged 1 commit into from
Dec 12, 2024
Merged

refactor(lsp/rpc): move transport logic to separate module #31514

merged 1 commit into from
Dec 12, 2024

Conversation

lewis6991
Copy link
Member

@lewis6991 lewis6991 commented Dec 8, 2024 •
edited
Loading

Simplifies vim.lsp.rpc.start() and vim.lsp.rpc.connect() and puts them both into very similar forms.

@github-actions github-actions bot added lsp refactor changes that are not features or bugfixes labels Dec 8, 2024
@github-actions github-actions bot requested a review from MariaSolOs December 8, 2024 10:36
@lewis6991 lewis6991 force-pushed the refactor/transport branch 3 times, most recently from 509d5d5 to b64007f Compare December 8, 2024 11:00
@lewis6991 lewis6991 marked this pull request as draft December 8, 2024 11:24
@github-actions github-actions bot removed the request for review from MariaSolOs December 8, 2024 11:24
@justinmk
Copy link
Member

This makes sense and maps to the layout in test/client/ (though the file names there could be improved, which I may do as part of #30384 )

@lewis6991 lewis6991 force-pushed the refactor/transport branch 2 times, most recently from f8a31fe to 45968ad Compare December 10, 2024 12:23
@lewis6991 lewis6991 marked this pull request as ready for review December 10, 2024 14:52
@github-actions github-actions bot requested a review from MariaSolOs December 10, 2024 14:52
justinmk
justinmk approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@justinmk justinmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably needs approval from someone who worked closely on this code

@lewis6991 lewis6991 merged commit 130f434 into neovim:master Dec 12, 2024
34 of 35 checks passed
@lewis6991 lewis6991 deleted the refactor/transport branch December 12, 2024 09:52
@github-actions github-actions bot removed the request for review from MariaSolOs December 12, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk approved these changes

@mfussenegger mfussenegger mfussenegger approved these changes

Assignees
No one assigned
Labels
lsp refactor changes that are not features or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewis6991 @justinmk @mfussenegger