Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Task Improvements (Patch, Strip, Recompile) #75

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Dec 14, 2023

This combines various task improvements aimed at reducing task inputs and thus the work that up-to-date checks and build-cache have to do.

  • Use DiffPatches ability to apply patches directly from ZIP-Files and use the NeoForm artifact as the source directly
  • Minor cleanup use try-with-resources in Strip
  • Don't use doLast in RecompileSources and instead move it in to the Task action
  • Don't cache ArtifactFromOutput since it's just a file copy (see Gradles own Copy task for similar reasoning on their part)

@marchermans
Copy link
Contributor

@shartte Can you update this?

@marchermans marchermans enabled auto-merge (squash) December 17, 2023 23:14
auto-merge was automatically disabled December 18, 2023 11:36

Head branch was pushed to by a user without write access

@shartte
Copy link
Contributor Author

shartte commented Dec 18, 2023

@marchermans Rebased

@marchermans marchermans merged commit 1b8c085 into neoforged:NG_7.0 Dec 18, 2023
2 checks passed
@shartte shartte deleted the task-improvements branch December 19, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants