Improve JSON Deserialization / Fix dangling file handles #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…well as not setting the UTF-8 character set explicitly (and thus falling back to the default platform encoding).
shartte
force-pushed
the
fix-io-stream-closure
branch
from
d0ddad6 to
d8eb5a5
Compare
marchermans
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSON serialization not closing the InputStream in some cases, as well as not setting the UTF-8 character set explicitly (and thus falling back to the default platform encoding).
This sometimes caused the version manifest file to be left open, causing subsequent updates to it to fail with access denied exceptions on Windows.