Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple AT files not working when final file name matches #41

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

pupnewfster
Copy link
Member

Currently for cases like Mekanism where we have multiple mods separated by sourceset but different submods may need additional AT files that have to be named accesstransformer.cfg so that they work in prod the AT generation is broken as it overrides the copies of the AT files with the last file. For example:

minecraft {
    accessTransformers {
        files(
                file('src/main/resources/META-INF/accesstransformer.cfg'),
                file('src/additions/resources/META-INF/accesstransformer.cfg')
        )
    }
}

Was only outputting a single file to build/neoForm/neoFormJoined1.20.2-20231019.002635/accesstransformers/User/accesstransformer.cfg which contained additions' ATs but not the base ones. This PR makes it so that it creates a second file in that folder called accesstransformer_1.cfg so that then when passing them along it can apply both of them. This is a similar solution as what is done for creating the task's name

@marchermans marchermans merged commit 8232cd5 into neoforged:NG_7.0 Nov 9, 2023
2 checks passed
@pupnewfster pupnewfster deleted the multiple_ats branch November 9, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants