Fix change in behavior of NeoFormRuntimeSpecification#getNeoFormVersion #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marchermans
approved these changes
Feb 27, 2024
shartte
reviewed
Feb 27, 2024
| public String getNeoFormVersion() { | ||
| return getVersion(); | ||
| return getVersion().substring(getVersion().lastIndexOf("-") + 1); |
There was a problem hiding this comment.
Doesn't this specifically revert the ability to use a branch-version of neoform successfully or am I misremembering?
There was a problem hiding this comment.
Hmm, maybe - how're those formatted? Do we need to use indexOf instead here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #86 caused a change in the behavior of
NeoFormRuntimeSpecification#getNeoFormVersion, in which it now returns versions in the formMCVERSION-TIMESTAMPinstead ofTIMESTAMP. This PR fixes this regression, and updates locations which make use of the new behavior to useSpecification#getVersioninstead, which returns the full MC-version-and-timestamp version string, as well as adding something to the javadoc of the method explaining which form is should return. I have tested this in neodev, and it creates an installer which works, and which can launch the game as a dedicated server successfully.