[1.21] Move Mod button below Realms and adjust branding text

[TelepathicGrunt]

The goal of this PR is to fix #249 issue and supersede #456 PR. The patch is smaller with this PR.

What is done is the Mod button is moved below the Realms button so both can be full width. Then the mod count in lower left corner was removed and instead, the mod count is now part of the Mod button text. Let me know if I done the lang file changes incorrectly.

Here's what it looked like on various screen sizes. Note, the NeoForge text in bottom left is super long only in PR branches. In prod, it would be NeoForge-20.6.76-beta which is much shorter and won't overlap the Mojang branding text in bottom right.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: eacd52ffb5c6809667f7962d749e4fd617ac8b8a.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:testframework:21.0.75-beta-pr-997-ModButton
• 📦 net.neoforged:neoforge:21.0.75-beta-pr-997-ModButton

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #997' // https://github.com/neoforged/NeoForge/pull/997
        url 'https://prmaven.neoforged.net/NeoForge/pr997'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr997.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr997
cd NeoForge-pr997
curl -L https://prmaven.neoforged.net/NeoForge/pr997/net/neoforged/neoforge/21.0.75-beta-pr-997-ModButton/mdk-pr997.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[TelepathicGrunt]

Slight change now. Moved all menu buttons up 12 pixels to keep it from feeling squished at bottom. Will not overlap with bottom text ever now. Can do 6 pixels instead if too high now

[TelepathicGrunt]

[TelepathicGrunt]

Note to self, add mod count to pause menu's mod button

[HenryLoenwind]

Looks like there's plenty of space, either left-aligned or centred in the remaining space...

[TelepathicGrunt]

That image you showed left aligned looks so bad. It’s inconsistent with the design of all other buttons. And I can see clearly if centered, the right side of realms will overlap the blue icon.

This is not the way

[TelepathicGrunt]

To be clear, I’m going to take some inspiration for Mod Menu on fabric to try some of their decisions but I really do not like how they replaced the feedback/bugs buttons entirely on the pause menu.

The mod count on the mod button should be fine. If the count is misleading, it would’ve been misleading anyway in bottom left corner. I’ll think about removing it but having it upfront might help reduce number of people asking why a mod isn’t working when it isn’t even on. Since they would see that their mod count didn’t go up upon adding a mod and know now to check their mods folder for if they grabbed the right jar and put it in right spot. I had a few cases where users didn’t realize the mod wasn’t on at all

[IMS212]

I believe replacing the feedback button is not only justified, but a good idea; modded users should not be reporting bugs to Mojang on a modded client ever.

[Gaming32]

Since 1.21, the feedback button is configurable by the server.

[Prospector]

To be clear, I’m going to take some inspiration for Mod Menu on fabric to try some of their decisions but I really do not like how they replaced the feedback/bugs buttons entirely on the pause menu.

In Mod Menu, these buttons are available inside the mods screen so they are redundant. Unsure if NeoForge does the same. In fact, I would think the report bugs button especially should not be a top-level button if you're running mods, because the bugs you encounter are less likely to be ones you should report to Mojang.

Also, including the mod count in the button is something I did a long time ago, and I had it formatted how you did in an early alpha version like 7 years ago. In the end, it was really inconsistent with how other buttons are labeled and people didn't like it a whole lot. In the end, I settled for making the default just say "Mods" with the count in the lower corner.

[Gaming32]

because the bugs you encounter are less likely to be ones you should report to Mojang

Again, in the case of a server, this button does not necessarily go to Mojang, but rather may go to the server's own bug report page, as defined by bug-report-link in server.properties. In addition, this button may be replaced by a "Server Links" button with arbitrary links if the minecraft:server_links packet is sent by the server.

[Prospector]

No, the report bugs button only ever goes to Mojang's URL (hardcoded to Urls.SNAPSHOT_BUGS in yarn), but it gets replaced by "Server Links" if the server provides that. Mod Menu does not replace or hide "Server Links", only the "Feedback", "Report Bugs", and "Give Feedback..." buttons which all only go to Mojang stuff, which is already inside Mod Menu under "Minecraft"

[TelepathicGrunt]

For reference, this is how serverlinks works:

[TelepathicGrunt]

Hmm

[TelepathicGrunt]

What we are setting on

[sciwhiz12]

Will merge in a few hours, to await any final feedback.

[Technici4n]

Didn't check the code but I like the design.