[1.21.4] Fix IClientItemExtensions#renderHelmetOverlay never being called

[IThundxr]

No description provided.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[neoforged-compatibility-checks]

@IThundxr, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 6d5e15590d1151b1c978add51b368379dfec0105.

neoforge (:neoforge)

• net/neoforged/neoforge/client/extensions/common/IClientItemExtensions
  • renderHelmetOverlay(Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/entity/player/Player;IIF)V: ❗ API method was removed

[ChampionAsh5357]

So, this method needs a rename and some smarter handling imo. Basically, what Gui#renderCamerOverlays is doing is checking every equipment slot to see whether the equipped item (with sanity checks for is actually equippable and in the proper slot) has a camera overlay. The else statement just says, 'oh attempt to render this every time regardless whether the item is in the correct location'. For example, even holding an item with the method implemented (instead of wearing it on the head) would call the rendering code.

Technically there are a few other asssumptions being made, such as the player must be in first person for the effect to be applied, but we'll assume it's only going to be rendered for first-person cameras that are not scoping. So, for this case, it would make more sense to call the method something like renderFirstPersonOverlay and have it render in conjunction with the texture overlay that can be present.

[IThundxr]

So, this method needs a rename and some smarter handling imo. Basically, what Gui#renderCamerOverlays is doing is checking every equipment slot to see whether the equipped item (with sanity checks for is actually equippable and in the proper slot) has a camera overlay. The else statement just says, 'oh attempt to render this every time regardless whether the item is in the correct location'. For example, even holding an item with the method implemented (instead of wearing it on the head) would call the rendering code.

Technically there are a few other asssumptions being made, such as the player must be in first person for the effect to be applied, but we'll assume it's only going to be rendered for first-person cameras that are not scoping. So, for this case, it would make more sense to call the method something like renderFirstPersonOverlay and have it render in conjunction with the texture overlay that can be present.

Those would be some good changes, i'll get them implemented and backported to 1.21.1

[IThundxr]

@ChampionAsh5357 I've went ahead and made some changes, let me know if you want any other changes

[ChampionAsh5357]

Looks good, just giving two quick pedantics.

[ChampionAsh5357]

One minor text change since it can be any equipment slot

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.4.58-beta.