Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c:flowers, c:flowers/tall, and c:flowers/small block and item tags #1825

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

TelepathicGrunt
Copy link
Contributor

@TelepathicGrunt TelepathicGrunt commented Jan 5, 2025

Mojang has recently rid minecraft:tall_flowers block tag and minecraft:tall_flowers/minecraft:flowers item tags.

What this PR aims to do is bring back and duplicate these flower tags under c namespace to make it safer for Modders to use without worry about Mojang deleting the rest of the flower tags in the future. We had multiple people ask where the flower item tag went so there is quite a number of people relying on a tag of flowers.

The non-tag entries of the flower tags are in same order as the tags in past (with exception to eye blossom because vanilla has the open and closed entry far apart in the vanilla for no logical reason which drove me insane)

For Fabric side, the c flower tags that still have a vanilla equivalent are aliased together.

I also added entries to log warning to find people using vanilla tags that no longer exist and guide them to the new c tags

Blocks:
c:flowers/tall
c:flowers/small
c:flowers

Items:
c:flowers/tall
c:flowers/small
c:flowers

Any issues with this? Is there any flower subcategory that is strongly desired beyond tall/small?

Fabric PR: FabricMC/fabric#4352

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 5, 2025

  • Publish PR to GitHub Packages

Last commit published: b089c674a2764d3417cdd67bac660daff3669144.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1825' // https://github.com/neoforged/NeoForge/pull/1825
        url 'https://prmaven.neoforged.net/NeoForge/pr1825'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1825.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1825
cd NeoForge-pr1825
curl -L https://prmaven.neoforged.net/NeoForge/pr1825/net/neoforged/neoforge/21.4.59-beta-pr-1825-FlowerTagRevival/mdk-pr1825.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt TelepathicGrunt enabled auto-merge (squash) January 14, 2025 13:48
@TelepathicGrunt TelepathicGrunt merged commit c0b028e into neoforged:1.21.x Jan 14, 2025
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.55-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants