Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to format mod description contents #1820

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Do not attempt to format mod description contents #1820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/neoforged/neoforge/client/gui/ModListScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ public void upload() {
lines.add(FMLTranslations.parseMessage("fml.menu.mods.info.updateavailable", vercheck.url() == null ? "" : vercheck.url()).replace("\r\n", "\n"));
lines.add(FMLTranslations.parseMessage("fml.menu.mods.info.license", selectedMod.getOwningFile().getLicense()).replace("\r\n", "\n"));
lines.add(null);
lines.add(FMLTranslations.parseMessageWithFallback("fml.menu.mods.info.description." + selectedMod.getModId(), selectedMod::getDescription));
lines.add(FMLTranslations.getPattern("fml.menu.mods.info.description." + selectedMod.getModId(), selectedMod::getDescription));

/* Removed because people bitched that this information was misleading.
lines.add(null);
Expand Down
2 changes: 1 addition & 1 deletion tests/src/main/resources/META-INF/neoforge.mods.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ license="LGPL v2.1"

[[mods]]
modId="neotests"
description="NeoForge tests. Change the language to fr_fr and the description should change too."
description="NeoForge's tests. Change the language to fr_fr and the description should change too."
enumExtensions="META-INF/enumextensions.json"
[[mods]]
modId="configui"
Expand Down
2 changes: 1 addition & 1 deletion tests/src/main/resources/assets/neotests/lang/fr_fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"fml.menu.mods.info.description.neotests": "Le mod de test de NeoForge oh la la !"
"fml.menu.mods.info.description.neotests": "Le mod de test de NeoForge oh la la ! J'aime le français !"
}
Loading