Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly resolve the parent in composite models #1819

Conversation

FiniteReality
Copy link
Member

It looks like there's a small bug where composite models don't resolve their parents properly, leading to missing texture references when baking. This change corrects that.

Before:
image

After:
image

@FiniteReality FiniteReality added regression Worked previously but doesn't anymore 1.21.4 Targeted at Minecraft 1.21.4 labels Jan 3, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 3, 2025

  • Publish PR to GitHub Packages

Last commit published: 52cc35178765b139465bdd1af06f9c305a7a50a7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1819' // https://github.com/neoforged/NeoForge/pull/1819
        url 'https://prmaven.neoforged.net/NeoForge/pr1819'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1819.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1819
cd NeoForge-pr1819
curl -L https://prmaven.neoforged.net/NeoForge/pr1819/net/neoforged/neoforge/21.4.49-beta-pr-1819-feature-composite-model-resolve-parent/mdk-pr1819.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@marchermans marchermans merged commit 05084dc into neoforged:1.21.x Jan 3, 2025
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.48-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 regression Worked previously but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants