Fix ArrowLooseEvent not firing for bows

[Spinoscythe]

Fixes #1188

This was just a TODO left during porting to 1.20.5

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[thomasglasser]

Wouldn't ArrowShotEvent or ArrowFiredEvent be a better name for it 🤔 ArrowLoose sounds weird. Not the point of the PR ik but I thought I'd suggest a rename.

[thomasglasser]

Actually it fires for bows no matter what the item is, which may not always be an arrow. BowShotEvent or BowFiredEvent would be better

[NewJumper]

or possibly rename it to ProjectileFireEvent to better match with the existing ProjectileImpactEvent?

[thomasglasser]

See that doesn't work bc it doesn't fire for every projectile, it fires from BowItem and CrossbowItem

[NewJumper]

oh yea, that's true

[sciwhiz12]

Patching the line with the instanceof ServerLevel is incorrect. While it prevents the arrow projectile from being spawned, it does not prevent the sound effect, the increment of the statistic, and the projectile item being consumed from the inventory.

(This should have been tested by adding an always-cancelling listener, which can be mimicked by modifying the EventHooks method to always return -1.)

The correct place to hook would be just after the getUseDuration call, in order to avoid those side-effects I mentioned above, and following the original patch as seen in 1.20.5.

[sciwhiz12]

Wouldn't ArrowShotEvent or ArrowFiredEvent be a better name for it 🤔

I would assume the name was decided to be the twin for ArrowNockEvent, which handles the bow being first drawn. (As to why they are not called BowDrawnEvent and BowFiredEvent, I don't exactly know.)

[HenryLoenwind]

I would assume the name was decided to be the twin for ArrowNockEvent, which handles the bow being first drawn.

That event name is at least 11.5 years old; i.e. it dates back to the time when there was only a bow and a single type of arrow. So, while the Nock event is its twin, the name was chosen because it properly fit back then.

[sciwhiz12]

Seems to work in my testing.

You need to clean up your patches. Re-add back unnecessarily removed blank lines, avoid renaming local variables without reason, etc.