Annotation marker fixes, javadoc cleanup, and LivingChangeTargetEvent methods renamed

[TelepathicGrunt]

Closes #655

And will fix some Javadoc to make some people happier lol.

remember, it is // Neo:. Not // NEO:. And do not do <p></p>. Do just <p>. And no more NEOFORGE START NEOFORGE END markers.

LivingChangeTargetEvent has its methods renamed to be more clear of what they represent. Also noticed a missing null check in the patch for that which could cause issues later if null got saved to the brain

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 56369ff1179473a373f801148808bdde2f766836.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.0.96-beta-pr-1147-MarkerAndJavadocCleanup
• 📦 net.neoforged:testframework:21.0.96-beta-pr-1147-MarkerAndJavadocCleanup

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1147' // https://github.com/neoforged/NeoForge/pull/1147
        url 'https://prmaven.neoforged.net/NeoForge/pr1147'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1147.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1147
cd NeoForge-pr1147
curl -L https://prmaven.neoforged.net/NeoForge/pr1147/net/neoforged/neoforge/21.0.96-beta-pr-1147-MarkerAndJavadocCleanup/mdk-pr1147.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[neoforged-compatibility-checks]

@TelepathicGrunt, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 56369ff1179473a373f801148808bdde2f766836.

neoforge (:neoforge)

• net/neoforged/neoforge/event/entity/living/LivingChangeTargetEvent
  • setNewTarget(Lnet/minecraft/world/entity/LivingEntity;)V: ❗ API method was removed
  • getOriginalTarget()Lnet/minecraft/world/entity/LivingEntity;: ❗ API method was removed
  • getNewTarget()Lnet/minecraft/world/entity/LivingEntity;: ❗ API method was removed

[sciwhiz12]

Merge when ready.