Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the MDK automatically update to the latest NeoGradle #30

Closed
wants to merge 1 commit into from
Closed

Make the MDK automatically update to the latest NeoGradle #30

wants to merge 1 commit into from

Conversation

Spinoscythe
Copy link

No description provided.

@TelepathicGrunt
Copy link

TelepathicGrunt commented Dec 23, 2023

I am not sure this is a good idea. If NeoGradle releases a breaking change, the MDK would be broken until someone makes a PR to fix it. It also means any mod using the MDK as a base will suddenly break one day and people won't know why. Updating NeoGradle should be a explicit action that the modder takes so they know if they are experiencing a breaking change or not

@TelepathicGrunt
Copy link

Unless of course, NeoGradle breaking changes are codified into the minor version number. Then 7.0.+ would be a better idea instead of 7.+

@Spinoscythe
Copy link
Author

Both achieve the same thing, so it isn't a big issue.

@Matyrobbrt
Copy link
Member

Due to the way the build and configuration cache behaves, any update to plugins will also cause an entire decomp/recomp cycle. So this will make people run that setup all over again for seemingly random reasons. Not to mention that reproducibility is also broken by the use of ranges in plugin versions, which gradle discourages. NG is rather stable right now and updates aren't that frequent. If people run into issues they can ask, and if it's fixed already we will tell them to update.

@Matyrobbrt Matyrobbrt closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants