Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the GUI #2

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Conversation

Matyrobbrt
Copy link
Member

@Matyrobbrt Matyrobbrt commented Jan 2, 2024

  • Remove clipping of the radio buttons; add spacing for better visibility;
  • Do not show non-advertised mirrors;
  • Make the version bold;
  • Make some messages correct (like in directory instead of at directory and minecraft -> Minecraft)
  • Disable the OK button when there's an error
  • Add a second progress bar for the steps, to show progress when downloading

image
image
image

@Matyrobbrt Matyrobbrt added the enhancement New feature or request label Jan 2, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 2, 2024

  • Publish PR to GitHub Packages

Last commit published: 725dfe01b1a0ba11151840c884aa217e580eab5e.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #2' // https://github.com/neoforged/LegacyInstaller/pull/2
        url 'https://prmaven.neoforged.net/LegacyInstaller/pr2'
        content {
            includeModule('net.neoforged', 'legacyinstaller')
        }
    }
}

@Matyrobbrt Matyrobbrt merged commit bcc2055 into neoforged:main Jan 2, 2024
2 checks passed
@Matyrobbrt Matyrobbrt deleted the gui-improvements branch January 2, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants