Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote native dependencies to compile-time dependencies if they're in all platforms #4

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Dec 9, 2024

This fixes LWJGL not being a compile-time dependency in 1.18.2, since they added it to all three platforms as a native dependency in that version (in order to make it a lower version for MacOS X).
I've made it so the lowest version is used as the compile-time dependency.

The MavenCoordinate class is copied from NFRT.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 9, 2024

  • Publish PR to GitHub Packages

Last commit published: d203a0d087370f70baad1e18e184fc8c4d30a7fc.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #4' // https://github.com/neoforged/GradleMinecraftDependencies/pull/4
        url 'https://prmaven.neoforged.net/GradleMinecraftDependencies/pr4'
        content {

        }
    }
}

@shartte shartte force-pushed the promote-natives-to-compile-time-dependencies branch from ad19379 to 6d2886f Compare December 9, 2024 11:28
@shartte shartte merged commit 9fe841d into main Dec 9, 2024
10 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.18.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.18.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.18.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.16.5.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.16.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.16.3.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.16.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.17.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.17.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.16.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.15.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.16.4.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.15.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.15.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.14.4.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.14.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.14.3.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.13.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.14.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.14.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.13.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.11.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.12.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.13.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.11.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.12.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.10.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.12.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.10.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.11.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.10.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.9.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.9.4.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.9.3.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.9.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.6.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.9.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.7.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.8.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.5.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.3.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.9.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.4.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.8.1.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.7.10.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.20.3.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.20.2.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 1.20.5.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 25w02a.

@neoforged-releases
Copy link

🚀 This PR has been released as GradleMinecraftDependencies version 25w03a.

@Matyrobbrt Matyrobbrt deleted the promote-natives-to-compile-time-dependencies branch January 18, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant