Add a trait to manage results of upgraders

Reset results after application of a patch to avoid the same messages multiples times

src/Patch/Manager.php

@@ -89,6 +89,7 @@ protected function processUpgrade(array $data): void
                 $upgrader->upgrade($data);
                 $this->errors = array_merge($this->errors, $upgrader->getErrors());
                 $this->success = array_merge($this->success, $upgrader->getSuccess());
+                $upgrader->resetResults();
             } catch (\Exception $e) {
                 $this->errors[] = 'Unable to upgrade data for upgrader ' . get_class($upgrader) .
                     ' error : ' . $e->getMessage();

src/Upgrader/Configuration.php

@@ -21,12 +21,11 @@
 
 class Configuration implements UpgraderInterface
 {
+    use UpgraderResultTrait;
+
     /** @var string Upgrader type */
     public const TYPE = 'configuration';
 
-    protected array $errors = [];
-    protected array $success = [];
-
     /**
      * @param array $data
      */
@@ -68,20 +67,4 @@ public function upgrade(array $data): void
             }
         }
     }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function getSuccess(): array
-    {
-        return $this->success;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function getErrors(): array
-    {
-        return $this->errors;
-    }
 }

src/Upgrader/Module.php

@@ -22,6 +22,8 @@
 
 class Module implements UpgraderInterface
 {
+    use UpgraderResultTrait;
+
     /** @var string Type d'upgrade */
     public const TYPE = 'modules';
 
@@ -33,8 +35,6 @@ class Module implements UpgraderInterface
 
     /** @var \PrestaShop\PrestaShop\Core\Addon\Module\ModuleManager */
     protected $moduleManager;
-    protected array $errors = [];
-    protected array $success = [];
 
     /**
      * {@inheritDoc}
@@ -191,20 +191,4 @@ public function upgradeUpdate(array $data): void
             }
         }
     }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function getSuccess(): array
-    {
-        return $this->success;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function getErrors(): array
-    {
-        return $this->errors;
-    }
 }

src/Upgrader/UpgraderInterface.php

@@ -41,4 +41,11 @@ public function getSuccess(): array;
      * @return array List of the errors of the process
      */
     public function getErrors(): array;
+
+    /**
+     * Reset the results of the upgrade
+     *
+     * @return void
+     */
+    public function resetResults(): void;
 }

src/Upgrader/UpgraderResultTrait.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace Hhennes\ModulesManager\Upgrader;
+
+/**
+ * Trait which allows to manage results upgrade process
+ */
+trait UpgraderResultTrait
+{
+    protected array $errors = [];
+    protected array $warning = [];
+    protected array $success = [];
+
+    /**
+     * {@inheritDoc}
+     */
+    public function getSuccess(): array
+    {
+        return $this->success;
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    public function getErrors(): array
+    {
+        return $this->errors;
+    }
+
+    /**
+     * Reset the results of the upgrade
+     *
+     * @return void
+     */
+    public function resetResults(): void
+    {
+        $this->success = [];
+        $this->errors = [];
+        $this->warning = [];
+    }
+}