feat: emit completion events (#3)

nelc · Dec 12, 2024 · 428cded · 428cded
1 parent 2dfb6e2
commit 428cded
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -52,4 +52,4 @@ jobs:
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
         flags: unittests
-        fail_ci_if_error: true
+        fail_ci_if_error: false
diff --git a/completion_aggregator/models.py b/completion_aggregator/models.py
@@ -190,12 +190,13 @@ def emit_completion_aggregator_logs(updated_aggregators):
             return
 
         for aggregator in updated_aggregators:
+            event = "progress" if aggregator.percent < 1 else "completion"
             block_type = aggregator.aggregation_name
 
             if block_type not in settings.COMPLETION_AGGREGATOR_TRACKING_EVENT_TYPES:
                 continue
 
-            event_name = f"openedx.completion_aggregator.progress.{block_type}"
+            event_name = f"openedx.completion_aggregator.{event}.{block_type}"
 
             tracker.emit(
                 event_name,