More APIs - Round 4 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadinaif
force-pushed
the
shadinaif/apis-round-3
branch
3 times, most recently
from
6f63342 to
114f46c
Compare
shadinaif
force-pushed
the
shadinaif/apis-round-3
branch
from
114f46c to
b2cdc8e
Compare
OmarIthawi
requested changes
Jun 12, 2024
|
|
||
| class AccessibleTenantsInfoView(APIView): | ||
| """View to get the list of accessible tenants""" | ||
| permission_classes = [] |
There was a problem hiding this comment.
Please add Token authentication and limit to superusers.
There was a problem hiding this comment.
@OmarIthawi , I added a rate limit for anonymous access. The API is accessible as anonymous or system-staff. No rate limit on system-staff users. Do we still need an API Key or Token? I guess not
and do not hide courses from detailed views
OmarIthawi
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
@shadinaif Looks good to me once the Token authentication is added to the tenant info API.
shadinaif
force-pushed
the
shadinaif/apis-round-3
branch
2 times, most recently
from
516f10c to
60114b7
Compare
shadinaif
force-pushed
the
shadinaif/apis-round-3
branch
from
60114b7 to
0a81452
Compare
shadinaif
force-pushed
the
shadinaif/apis-round-3
branch
from
2818a43 to
16938ca
Compare
shadinaif
force-pushed
the
shadinaif/apis-round-3
branch
from
16938ca to
95cbbd3
Compare
|
API key to be added later #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.4.5
v0.4.3