Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci/authentication/use GitHub secrets instead of vault #2901

Closed
wants to merge 11 commits into from
Closed

Ci/authentication/use GitHub secrets instead of vault #2901

wants to merge 11 commits into from
+25 −71

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

smokestacklightnin and others added 11 commits December 23, 2024 23:12
@smokestacklightnin
Use GitHub secrets instead of Vault in test-provider.yaml
b516533
@smokestacklightnin
Use GitHub secrets instead of Vault in test_aws_integration.yaml.
a12c84e
@smokestacklightnin
Use GitHub secrets instead of Vault in test_azure_integration.yaml.
818215d
@smokestacklightnin
Use GitHub secrets instead of Vault in test_gcp_integration.yaml.
8a6ec44
@marcelovilla
Add PROJECT_ID to env variables from GH secrets
66ff355
@marcelovilla
Add Azure env variables
470e981
@marcelovilla
Merge branch 'main' into ci/authentication/use-github-secrets-instead…
d3a7b90 
…-of-vault
@marcelovilla
Add CLOUDFLARE_TOKEN to environment variables
e4fd341
@marcelovilla
Merge branch 'main' into ci/authentication/use-github-secrets-instead…
1dae9a9 
…-of-vault
@marcelovilla
Move env variables inside integration tests step
bd51246
@marcelovilla
Merge branch 'ci/authentication/use-github-secrets-instead-of-vault' of
7def1a2 
https://github.com/nebari-dev/nebari into ci/authentication/use-github-secrets-instead-of-vault
@marcelovilla
Copy link
Member Author

Closing this PR as it was only opened to trigger cloud integration tests from this PR that could not be triggered from a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelovilla @smokestacklightnin