Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sha256 sum for git-lfs script #161

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix sha256 sum for git-lfs script #161

merged 1 commit into from
Jun 17, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Jun 17, 2024

Reference Issues or PRs

Fixes #159

I have skimmed over the script to make sure its coming from official sources:
https://packagecloud.io/github/git-lfs/packages/ubuntu/focal/git-lfs_3.5.1_amd64.deb?distro_version_id=210

Ideally we should download the .deb from above link and then verify the checksum given in the above link, but that's probably for another time. This is to unblock us from updating images.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@aktech aktech requested a review from krassowski June 17, 2024 14:55
@aktech aktech mentioned this pull request Jun 17, 2024
18 tasks
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I download locally see the new checksum (8c4d07257b8fb6d612b6085f68ad33c34567b00d0e4b29ed784b2a85380f727b).

I was able to find 5fc673f9a72b94c011b13eb5caedc3aa4541b5c5506b95d013cb7ba0f1cf66cf from wayback machine and the diff appears to be literally one extra empty line at line 196 (opening the current file and removing that line restores the old hash).

@aktech aktech merged commit 4f1d940 into main Jun 17, 2024
11 checks passed
@aktech aktech deleted the fix-git-lfs-hash branch June 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Builds are failing due to a change in git-lfs script
2 participants