Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images for arm architecture #141

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-push-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,4 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max
build-args: BASE_IMAGE=${{ env.BASE_IMAGE }}
platforms: linux/amd64,linux/arm64
3 changes: 2 additions & 1 deletion Dockerfile.dask-worker
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# docker build -f Dockerfile.dask-worker -t nebari-dask-worker:latest .

ARG BASE_IMAGE=ubuntu:20.04
FROM $BASE_IMAGE

Check warning on line 10 in Dockerfile.dask-worker

View workflow job for this annotation

GitHub Actions / build-test-images (dask-worker, gpu)

Always tag the version of an image explicitly

Check warning on line 10 in Dockerfile.dask-worker

View workflow job for this annotation

GitHub Actions / build-test-images (dask-worker, cpu)

Always tag the version of an image explicitly

Check warning on line 10 in Dockerfile.dask-worker

View workflow job for this annotation

GitHub Actions / build-test-images (dask-worker, gpu)

Always tag the version of an image explicitly

Check warning on line 10 in Dockerfile.dask-worker

View workflow job for this annotation

GitHub Actions / build-test-images (dask-worker, cpu)

Always tag the version of an image explicitly
LABEL MAINTAINER="Nebari development team"

COPY scripts/install-apt-minimal.sh /opt/scripts/install-apt-minimal.sh
Expand All @@ -16,7 +16,8 @@
COPY scripts/fix-permissions /opt/scripts/fix-permissions

ENV MAMBAFORGE_VERSION 4.13.0-1
ENV MAMBAFORGE_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
ENV MAMBAFORGE_AARCH64_SHA256 69e3c90092f61916da7add745474e15317ed0dc6d48bfe4e4c90f359ba141d23
ENV MAMBAFORGE_X86_64_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
SHELL ["/bin/bash", "-c"]

ENV PATH=/opt/conda/bin:${PATH}:/opt/scripts
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile.jupyterhub
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ RUN /opt/scripts/install-apt-minimal.sh
COPY scripts/fix-permissions /opt/scripts/fix-permissions

ENV MAMBAFORGE_VERSION 4.13.0-1
ENV MAMBAFORGE_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
ENV MAMBAFORGE_AARCH64_SHA256 69e3c90092f61916da7add745474e15317ed0dc6d48bfe4e4c90f359ba141d23
ENV MAMBAFORGE_X86_64_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
SHELL ["/bin/bash", "-c"]

ENV PATH="/opt/conda/bin:$PATH:/opt/scripts"
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile.jupyterlab
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# docker build -f Dockerfile.jupyterlab -t nebari-jupyterlab:latest .

ARG BASE_IMAGE=ubuntu:20.04
FROM $BASE_IMAGE

Check warning on line 10 in Dockerfile.jupyterlab

View workflow job for this annotation

GitHub Actions / build-test-images (jupyterlab, gpu)

Always tag the version of an image explicitly

Check warning on line 10 in Dockerfile.jupyterlab

View workflow job for this annotation

GitHub Actions / build-test-images (jupyterlab, cpu)

Always tag the version of an image explicitly

Check warning on line 10 in Dockerfile.jupyterlab

View workflow job for this annotation

GitHub Actions / build-test-images (jupyterlab, gpu)

Always tag the version of an image explicitly

Check warning on line 10 in Dockerfile.jupyterlab

View workflow job for this annotation

GitHub Actions / build-test-images (jupyterlab, cpu)

Always tag the version of an image explicitly
LABEL MAINTAINER="Nebari development team"

ENV LANG=C.UTF-8 LC_ALL=C.UTF-8
Expand All @@ -18,7 +18,8 @@
COPY scripts/fix-permissions /opt/scripts/fix-permissions

ENV MAMBAFORGE_VERSION 4.13.0-1
ENV MAMBAFORGE_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
ENV MAMBAFORGE_AARCH64_SHA256 69e3c90092f61916da7add745474e15317ed0dc6d48bfe4e4c90f359ba141d23
ENV MAMBAFORGE_X86_64_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
SHELL ["/bin/bash", "-c"]
ENV CONDA_DIR=/opt/conda \
DEFAULT_ENV=default
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile.workflow-controller
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ RUN /opt/scripts/install-apt-minimal.sh
COPY scripts/fix-permissions /opt/scripts/fix-permissions

ENV MAMBAFORGE_VERSION 4.13.0-1
ENV MAMBAFORGE_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
ENV MAMBAFORGE_AARCH64_SHA256 69e3c90092f61916da7add745474e15317ed0dc6d48bfe4e4c90f359ba141d23
ENV MAMBAFORGE_X86_64_SHA256 412b79330e90e49cf7e39a7b6f4752970fcdb8eb54b1a45cc91afe6777e8518c
SHELL ["/bin/bash", "-c"]
ENV CONDA_DIR=/opt/conda \
DEFAULT_ENV=default
Expand Down
13 changes: 11 additions & 2 deletions scripts/install-conda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,17 @@
set -xe

# Requires environment MAMBAFORGE_SHA256, MINIFORGE_VERSION, and DEFAULT_ENV
wget --quiet -O mambaforge.sh https://github.com/conda-forge/miniforge/releases/download/$MAMBAFORGE_VERSION/Mambaforge-Linux-x86_64.sh
echo "${MAMBAFORGE_SHA256} mambaforge.sh" >mambaforge.checksum
arch=$(uname -i)
wget --quiet -O mambaforge.sh https://github.com/conda-forge/miniforge/releases/download/$MAMBAFORGE_VERSION/Mambaforge-Linux-$arch.sh

if [[ $arch == "aarch64" ]]; then
echo "${MAMBAFORGE_AARCH64_SHA256} mambaforge.sh" >mambaforge.checksum
elif [[ $arch == "x86_64" ]]; then
echo "${MAMBAFORGE_X86_64_SHA256} mambaforge.sh" >mambaforge.checksum
else
echo "Unsupported architecture: $arch"
exit 1
fi

echo $(sha256sum -c mambaforge.checksum)

Expand Down
Loading