Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cargo-bolero with a fix for cargo bolero list with failing tests #10131

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Ekleog-NEAR
Copy link
Collaborator

We have tests that fail with cargo test, and this throws off cargo bolero list, that runs cargo test to list the fuzzers.

With this change, we add camshaft/bolero#195, that ignores such failures and actually lists all fuzzers.

This should fix the issue, that all the latest uploads to the fuzzers bucket actually were empty tarballs.

@Ekleog-NEAR Ekleog-NEAR requested a review from nagisa November 8, 2023 17:49
@Ekleog-NEAR Ekleog-NEAR requested a review from a team as a code owner November 8, 2023 17:49
Copy link
Collaborator

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, so running cargo bolero list will also run the entire test suite? That doesn’t sound like an efficient way to approach the task, but isn’t something to block landing this over.

@Ekleog-NEAR Ekleog-NEAR enabled auto-merge November 9, 2023 11:36
@Ekleog-NEAR
Copy link
Collaborator Author

It currently does, I currently remember chatting with camshaft and resulting in this idea, but can’t find it again on the github issue tracker, so I just opened an issue there :)

@Ekleog-NEAR Ekleog-NEAR added this pull request to the merge queue Nov 9, 2023
Merged via the queue into near:master with commit 8830d10 Nov 9, 2023
@Ekleog-NEAR Ekleog-NEAR deleted the fix-bolero-list branch November 9, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants