feat: impl BorshSerialize/BorshDeserialize/BorshSchema for char
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
force-pushed
the
char_impl
branch
2 times, most recently
from
a40db0f to
e18f3b3
Compare
dj8yfo
changed the title
BorshSerialize/BorshDeserialize for charBorshSerialize/BorshDeserialize/BorshSchema for char
|
FYI, Unicode character is 21-bit number. This could be optimised to encode as 3-byte little endian number. (Another alternative is to use UTF-8 which would be more in line with how strings are serialised). |
|
@mina86 Thanks for pointing that out. I have also raised a concern (#247 (comment)) that maybe we should not implement it in borsh unless we strictly define what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #247