Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export nip17 #458

Merged
merged 3 commits into from
Nov 26, 2024
Merged

export nip17 #458

merged 3 commits into from
Nov 26, 2024

Conversation

Egge21M
Copy link
Contributor

@Egge21M Egge21M commented Nov 25, 2024

Added nip17 export to index.ts for bundlers that do not support exports yet

@fiatjaf
Copy link
Collaborator

fiatjaf commented Nov 26, 2024

Just out of curiosity, what are these bundlers?

@Egge21M
Copy link
Contributor Author

Egge21M commented Nov 26, 2024

Just out of curiosity, what are these bundlers?

While supported in react-native / metro, it's a real pain to make it work and is very likely to break other stuff

@fiatjaf fiatjaf merged commit bbb0942 into nbd-wtf:master Nov 26, 2024
2 checks passed
@fiatjaf
Copy link
Collaborator

fiatjaf commented Nov 26, 2024

OK, I'm going to merge this, but I wanted to actually go the other way because there are way too many people using this index file without knowing better.

Maybe I'll release a v3 soon that gets rid of the index file altogether and makes other changes.

@Egge21M
Copy link
Contributor Author

Egge21M commented Nov 26, 2024

OK, I'm going to merge this, but I wanted to actually go the other way because there are way too many people using this index file without knowing better.

Thanks!

I see your point, but isn't that on them? By getting rid of the main entry file, you will loose backwards compatibility and force bundler updates and settings on consumers. Keeping both lets people opt-in to better tree shaking. If they don't they either can't or... skill issues.

Also you need the index files anyways for standalone bundles, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants