nip19: remove note1.

[AsaiToshiya]

Related: nostr-protocol/nips#1586

[eskema]

this feels very wrong to me

[fiatjaf]

Why?

[eskema]

because the decode function is still needed to read all the past content that is already out there, and there are probably a lot of code that depends on this functions existing to continue working. (at least mine does) It’s one thing to have clients phase it out, but it’s another to just break things in clients that still use it

[fiatjaf]

He is right, @AsaiToshiya.

[AsaiToshiya]

What about encoding? Is it necessary?

This PR is just a suggestion and I don't mind if you revert changes.

[fiatjaf]

Encoding we should remove.

[AsaiToshiya]

Ok, I'll open another PR.

[eskema]

I use note1 encoding for note ids since we moved out of showing hex strings to users a long long time ago, nevent and naddr cannot be used for such which leaves me with no other option than reverting back to hex strings. fun

[fiatjaf]

Why can't you use nevent? Of course you can and should!