Manage OIDC provider outside of terraform #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #531
Changes
see title
Context for reviewers
see ticket
Testing
This change was pulled directly from somewhere else (it was originally a PR authored by @anybodys reviewed by @daphnegold) so it's already been tested there. And it also should be covered by CI.
This change moves the OIDC provider to be managed outside of Terraform. Thus, to prevent Terraform from destroying that resource, you need to remove the OIDC provider from the Terraform state file for each of your accounts in infra/accounts. Run the following commands for each AWS account:
./bin/terraform-init.sh infra/accounts $(./bin/current-account-config-name.sh) terraform -chdir=infra/accounts state rm module.auth_github_actions.aws_iam_openid_connect_provider.github