Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown link checker + fix links #331

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add Markdown link checker + fix links #331

merged 2 commits into from
Apr 29, 2024

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Apr 29, 2024

Ticket

Resolves #264

Context for reviewers

The infra template includes a workflow that is installed along with the template. This just adds a template-only workflow so the CI catches bad links as they happen.

Testing

https://github.com/navapbc/template-application-nextjs/actions/runs/8884261284/job/24392951892?pr=331

@sawyerh sawyerh requested review from lorenyu and a team April 29, 2024 19:22
@@ -1,6 +1,6 @@
# Dependency Management with Renovate

Out of the box this repo uses [Renovate](https://docs.renovatebot.com/) for dependency management. More information on the decision to try renovate can be found [here](https://github.com/navapbc/template-application-nextjs/blob/main/docs/decisions/0002-use-renovate-for-dependency-updates.md). Renovate is free and open-source and allows us to bundle dependency updates together and customize their scheduling.
Out of the box this repo uses [Renovate](https://docs.renovatebot.com/) for dependency management. More information on the decision to try renovate can be found [here](../docs/decisions/template/0001-use-renovate-for-dependency-updates.md). Renovate is free and open-source and allows us to bundle dependency updates together and customize their scheduling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I now strip out renovate now that dependabot can bundle 🤔 Can file a follow-up issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly! It's working and its Dependency Dashboard is nice, so I don't think there's any urgency at the moment at least.

@sawyerh sawyerh merged commit 850a812 into main Apr 29, 2024
1 check passed
@sawyerh sawyerh deleted the sawyerh/264-md-links branch April 29, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add template-only markdown link linter.
3 participants