Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service config options to env-config #75

Closed
wants to merge 4 commits into from

Conversation

lorenyu
Copy link
Collaborator

@lorenyu lorenyu commented Dec 12, 2023

Ticket

N/A

Changes

  • Add env-config settings for service CPU, memory, and desired instance count
  • Set prod to 1 vCPU, 4 GB memory, and 3 instances
  • Add instructions

Context

Add env-config settings for setting an environment's service's CPU, memory, and desired instance count. This allows a project to have separate settings for each environment.

Testing

Temporarily set app-config's has_database to false (so we don't need to create a prod database layer), and set prod.tf's config to set network_name to "dev" (so we don't need to create a prod VPC), then ran terraform plan for prod. Here are the relevant sections that show that desired count is 3 and that CPU and memory settings are different from the defaults:

Ran the following commands (image_tag is the current commit on main branch)

make infra-configure-app-service APP_NAME=app ENVIRONMENT=prod
TF_CLI_ARGS_apply='-var=image_tag="0b7fbe62bb7a925ffd314dae444ab3a84b968701"' make infra-update-app-service APP_NAME=app ENVIRONMENT=prod

Terraform plan screenshots:

image image

@lorenyu lorenyu changed the title WIP Lorenyu/configservice Add service config options to env-config Dec 12, 2023
@lorenyu
Copy link
Collaborator Author

lorenyu commented Dec 14, 2023

Done in navapbc/template-infra#503

@lorenyu lorenyu closed this Dec 14, 2023
@lorenyu lorenyu deleted the lorenyu/configservice branch December 14, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant