Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Terraform version #166

Closed
wants to merge 4 commits into from
Closed

Conversation

daphnegold
Copy link
Contributor

@daphnegold daphnegold commented Jan 23, 2025

Ticket

Resolves #685

Changes

  • Minor version Terraform upgrade from 1.8.3 to 1.10.5

Note

Some files are autogenerated via jinja template resulting in a difference in pull request files changed between template-infra and platform-template repos.

Testing

Github Actions using Terraform version 1.10.5 pass ✅

Screenshot Spam
Screenshot 2025-01-23 at 3 13 10 PM
Screenshot 2025-01-23 at 3 12 39 PM
Screenshot 2025-01-23 at 3 11 57 PM
Screenshot 2025-01-23 at 3 10 46 PM
Screenshot 2025-01-23 at 3 07 52 PM
Screenshot 2025-01-23 at 10 02 56 AM
Screenshot 2025-01-23 at 10 02 17 AM

Preview environment for app

♻️ Environment destroyed ♻️

Preview environment for app-rails

♻️ Environment destroyed ♻️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor the setup-terraform steps to use the custom action ./.github/actions/setup-terraform (see other files where we use that action)

Copy link
Contributor Author

@daphnegold daphnegold Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll check it out

EDIT: so much better, got rid of all the references everywhere that would need to be updated with the wrapper

@daphnegold daphnegold requested a review from lorenyu January 24, 2025 22:50
@daphnegold daphnegold closed this Jan 27, 2025
@daphnegold
Copy link
Contributor Author

Done in navapbc/template-infra#852

@daphnegold daphnegold deleted the daphnegold/685-terraform-version branch January 27, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants