Fix trigger for PR environment destroy workflow #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where PR environment destroy workflow is not triggered when there is a conflict with the base branch
|
Done in navapbc/template-infra#827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where PR environment destroy workflow is not triggered when there is a conflict with the base branch
Ticket
Resolves navapbc/template-infra#826
Changes
see title
Context for reviewers
see ticket. i looked into why PRs were being orphaned and discovered it's not because PR destroy workflow was failing but because it wasn't being triggered at all.
Testing
I can't easily fix this by closing the PR because the new trigger runs the destroy/cleanup from the base
mainbranch which has the wrong trigger.Preview environment
♻️ Environment destroyed ♻️