Add Mutex class #1347
Closed
Add Mutex class #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has stubs methods lock and unlock
For our current Mutex specs, we can just try to see if a ThreadError is thrown. This should be changed to something more sensible. The upstream specs use a watcher Thread, but that won't work for us. We can probably use the Fiber scheduler to catch callbacks.
|
I'm removing this one, in favour of #1541 |
|
Dang I completely forgot about this existing PR. 🤦♂️ Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need this one for the block/unblock in #1184. Most of the upstream specs will probably fail, since they all depend on threads, we might have to duplicate a few of them using fibers.
Once we have this one, we can probably build the other synchronisation primitives (like Queue and ConditionVariable) in plain Ruby using this Mutex class, and get the Scheduler hooks for free.