Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IO#select #1268

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Implement IO#select #1268

merged 4 commits into from
Sep 29, 2023

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Sep 29, 2023

This should be the final shaved yak before we can work on the io_wait example with unblocked Fibers (#1184)

@herwinw
Implement Object::to_io
1f07a4e 
This is comparable to Object::to_str
@herwinw
Import specs for IO.select
6cd3181
@herwinw
Disable specs for IO.select failing for other reasons
69f595d 
Rewrite the tests in code that we do support whereever possible.
@herwinw
Implement IO.select
2404ab1
seven1m
seven1m approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@seven1m seven1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@herwinw herwinw merged commit 617ac1b into natalie-lang:master Sep 29, 2023
@herwinw herwinw deleted the io_select branch September 29, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven1m seven1m seven1m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herwinw @seven1m