Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1658: Do not pin the version of xarray. #15

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

chris-durbin
Copy link
Contributor

Jira Issue ID

Harmony-1658

Description

Do not pin the version of xarray. Users that wanted to install the zarr-eosdis-store were seeing xarray downgraded in their python environment, but they needed a later version of xarray for other libraries in their environment.

Local Test Steps

As far as I can tell there was no reason xarray was pinned, however this repo has several failing tests at the moment. The root cause of those failures is that the tests were relying on files that no longer exist. We'll need to figure out how to reconstruct those missing files and ensure in the future they are under our control and cannot be removed.

I did verify that with the latest version of xarray there are no new test failures - everything passing continues to pass.

To test:

  1. Set your python environment
  2. pip install -r requirements.txt
  3. pip install -r requirements-dev.txt
  4. pip install xarray --upgrade
  5. Verify that your version of xarray is the latest (2024.1.1)
  6. pip install -r requirements.txt
  7. Verify that xarray is not downgraded
  8. coverage run -m pytest
  9. Verify that 4 of 14 tests pass

@chris-durbin chris-durbin merged commit d47a1f9 into main Feb 2, 2024
2 of 3 checks passed
@chris-durbin chris-durbin deleted the harmony-1658 branch February 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants