Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical severity vulnerability introduced via matplotlib. #13

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

owenlittlejohns
Copy link
Member

This PR fixes a vulnerability reported by Snyk. pillow, which is a dependency of matplotlib needs to be updated (see report here).

The reported vulnerability has a critical severity.

@owenlittlejohns
Copy link
Member Author

It looks like there was an attempted test run a couple of months back that had the same test failures. I'm tempted to say they are out of scope, as this PR only addresses dependencies used for the Jupyter notebook documentation.

@chris-durbin
Copy link
Contributor

It looks like there was an attempted test run a couple of months back that had the same test failures. I'm tempted to say they are out of scope, as this PR only addresses dependencies used for the Jupyter notebook documentation.

We recently looked at this, and I believe it's related to needing EDL credentials saved as a secret but we haven't had luck working with admins to get secrets added to our repos. Agreed you don't need those tests to pass to merge.

@owenlittlejohns owenlittlejohns merged commit 6348163 into main Oct 6, 2023
1 check failed
@owenlittlejohns owenlittlejohns deleted the snyk-vulnerability-fix branch October 6, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants