-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from upstream including relative winds #270
base: develop
Are you sure you want to change the base?
Conversation
Merge pull request nansencenter#264 from TillRasmussen/develop
Based on this current branch, the model was compiled on Betzy and the one-month run has been done. In addition, the codes between lines of 498 and 514 in mod_momtum.F90 are possible to be shorten. Because when the ocnscl equals 0.0, the results both are same. |
The reason that it is implemented like this is that it is taken from the upstream code. @Jipingnersc Just to be sure the code do not fail when ocnscl is 0.0?. It "just" exit due to statements. blkdat.F90 exit 1) ocnscl=0. (no influence of currents on wind) and wndflg>=4 (influence of currents on wind) exit 2) ocnscl>0. wndflg<4: Comments mod_momtum.F90 |
Added upstream changes and a few bugfixes
Changed epmass to integer. Check if NERSC error message is correct in blkdat.input (reviewers)
Added variable use of ocean current in (ocnscl) Default is 1.0 which will result in full relative wind (windx-ocnscl*Uocn). See mod_momtum. This should result in removal of negative wndflg and removal of amoflg as this no longer make sense. I will suggest that to the upstream. Note this is the only part which changes the md5sum (bit for bit check of restart after one day).
A conservative cfl flag criterion is added when cpp flag momtum_cfl is added. This is not tested and to not change result when false.
Added hybthk. Default to normal when set to 0.0. A way of avoiding to thin hybrid layers. There is a bug as the pressure p(kdm) sometimes is smaller than p(kdm+1), which is unphysical as it represents a layer with negative thickness at the bottom. This seems to be a numerical issue and it is only in the order of a few mm. Solved by requiring that the difference cannot be lower than 0. Another thing to raise to upstream. This is not related to this implementation.
I found a parenthesis missing in a cpp block that required STOKES added. This is located in mod_barotrop. I have not checked that it is correct as I dont run with this