Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: server error handling improvements and tests #2083

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Jan 12, 2025

We want to consume the request properly on an error, so that we can give a reasonable response. We were prematurely closing the connection for certain failure modes. We still have to fix overly long URIs and headers, but thats next!

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.66%. Comparing base (169166a) to head (c34abc2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/supplemental/http/http_msg.c 53.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   83.57%   83.66%   +0.08%     
==========================================
  Files          93       93              
  Lines       23501    23503       +2     
  Branches     3035     3035              
==========================================
+ Hits        19642    19663      +21     
+ Misses       3783     3762      -21     
- Partials       76       78       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We want to consume the request properly on an error, so that
we can give a reasonable response.  We were prematurely closing
the connection for certain failure modes.  We still have to fix
overly long URIs and headers, but thats next!
The data is now passed directly to the handler function.
@gdamore gdamore merged commit c34abc2 into main Jan 12, 2025
35 of 37 checks passed
@gdamore gdamore deleted the server-uri-tests branch January 12, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant