Database backend configuration #4828
Open
+50
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the database backend is determined by the setting of
RocksDb.Enable
config setting which is not very intuitive.This PR replaces that setting with a new
database_backend
setting. It can be set to eitherlmdb
orrocksdb
. If not set, it defaults tolmdb
.To make it easier for node operators that are currently using RocksDb, the node will notify the operator with an error message if the config file has the old
RocksDb.Enable
set to true anddatabase_backend
set to lmdb (for example when using an old config file that does not have the new database_backend property). The error message can be removed in future versions when operators have migrated to use the newdatabase_backend
typeThis PR also makes it easier to add more backends in the future.