-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ilc): fix removing css link for embedded app #619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2broth
force-pushed
the
fix/embedded_app_remove_css
branch
2 times, most recently
from
October 10, 2024 07:17
22d4bad
to
460fee4
Compare
m2broth
force-pushed
the
fix/embedded_app_remove_css
branch
from
October 10, 2024 07:25
460fee4
to
4390e1d
Compare
m2broth
requested review from
blackrabbit99,
b1ff,
wRLSS,
yehor-manzhula and
stas-nc
October 10, 2024 07:33
wRLSS
reviewed
Oct 10, 2024
wRLSS
reviewed
Oct 15, 2024
wRLSS
approved these changes
Oct 15, 2024
yehor-manzhula
approved these changes
Oct 15, 2024
Coverage ReportIlc/serverCommit SHA:40fb0008ce5291803014a4f4887c472d20c4e353 Test coverage results 🧪
File details
Ilc/clientCommit SHA:40fb0008ce5291803014a4f4887c472d20c4e353 Test coverage results 🧪
File details
RegistryCommit SHA:40fb0008ce5291803014a4f4887c472d20c4e353 Test coverage results 🧪
File details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed removing embedded application CSS link when application is unmounted during route change