Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new theme for (Un)colored : Black-Room Theme #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guillotjulien
Copy link

Hello,

I'm really interested in your project so I've tried to create a new theme : the Black-Room Theme.
In the future I'll try to add ChartJs support and pdf export but I have to understand all the code before that.

Thank you for your work !
PS: It's my first time using github so I don't really know if it'll work :)

@n457
Copy link
Owner

n457 commented Dec 3, 2017

Hi @skyeun, thanks a lot for your interest !

Right now and for the past 3-4 months, I'm busy on the next major version, and I really don't think I will release another version before that :(

I was busy extracting (Un)colored core functionnalities and making it a dedicated library (in TypeScript & JavaScript, for Node.js & the browser). It's done, and right now I'm creating a more professional interface (which is dark) under Angular 5. If you wanna help with funtionnalities, keep this framework in mind ;)

Sorry, I can't merge your request for those reasons :( Can you make me a screenshot though so I can see your work ? :)

Added black-room theme preview image
@guillotjulien
Copy link
Author

Hello,

I added the preview image for Black-room theme :)

I'll like a lot to help you with these functionalities but before that, I have to learn Angular and TypeScript :)

I think it's a great idea to create a dedicated library and I'll pay a close attention to your project ;)

@ghost
Copy link

ghost commented May 4, 2018

I believe that Theme is a really important criterium when a user chooses an application. Maybe you could some help just to approve/reject themes. Another alternative is to create a branch only for themes, so we could download them from here. I really liked the app, but the white theme isn't comfortable to me. Maybe you could make available a "dark theme" just for the people that are more comfortable with it. I hope it helps.

@n457
Copy link
Owner

n457 commented May 20, 2018

@skyeun I've seen your screenshot the day you posted it (I had no time to answer, and then I forgot, sorry 😟 ), it's really cool 👍 , for the info : the dark theme/mode for version 1.0 is pretty near from that 😉

@almir-campos When version 1.0 development started, I included User Interface (UI) themes management, and pretty quick, big questions kicked in :

  1. How far will theme customization go ? Just colors ? Full CSS ?
  2. Will this affect User eXperience (UX) ?
  3. Is this time consuming to implement, to extend, to maintain ?
  4. Is that coherent with the new professional turn of the software ?

I thought a lot about this, made research, tests, and have answered thoses questions :

  1. I tested colors only and full CSS customization, and both can go pretty far (and wrong) with how the software can look, and degrade its "marketing" image, make it less serious, less professional.
  2. So this leads us to : yes, this will affect UX, and I want to have full control of that.
  3. It's a bit time consuming to implement, but it's not that big of a deal.
  4. No it's not. Professional softwares want to have full control of what users perceive, how, and how fast.

So no, UI themes creation and management will not be a thing for those reasons, but don't worry, a very nice dark theme is already implemented for version 1.0 😉

@elevenpassin
Copy link

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants