feat(iroh)!: Remove access to local and remote IP addresses

[flub]

Description

The Connecting and Connection structs exposed IP addresses, these are
probably the NodeIdMappedAddresses rather than real ones. We address
based on NodeId, so let's remove this stuff.

Breaking Changes

iroh

• Connecting::local_ip is removed.
• Connecting::remote_address is removed.
• Connection::local_ip is removed.
• Connection::remote_address is removed.

Notes & open questions

I didn't think long about this. Getting this PR out so someone else
can think carefully about this. :)

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.
• Tests if relevant.
• All breaking changes documented.

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3148/docs/iroh/

Last updated: 2025-01-23T14:59:07Z

[github-actions]

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 23f3b87

[matheus23]

Agreed we should remove the current version.

At some point it might be nice to add a version back that allows denylisting incoming connections by IP addr, if they misbehave often enough.
For that, we'd need the non-mapped addresses though. And also would need more design (unsure about how to realize this with relays).

[flub]

Agreed we should remove the current version.

At some point it might be nice to add a version back that allows denylisting incoming connections by IP addr, if they misbehave often enough. For that, we'd need the non-mapped addresses though. And also would need more design (unsure about how to realize this with relays).

Yes, note that Incoming is the first struct you get on the accept side and this still has the local and remote IP methods. Though they are probably also the wrong IPs and the thing does need more design.